Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make adding InputSchemes more User friendly #549

Merged
merged 7 commits into from
Aug 9, 2022
Merged

Make adding InputSchemes more User friendly #549

merged 7 commits into from
Aug 9, 2022

Conversation

Bashar-Ahmed
Copy link
Contributor

No description provided.

@Bashar-Ahmed Bashar-Ahmed linked an issue Feb 16, 2022 that may be closed by this pull request
Effectively Map Keys directly to GaInput enums #539
Closed
sin3point14
sin3point14 reviewed Feb 16, 2022
View reviewed changes
rootex/framework/scene.cpp Outdated Show resolved Hide resolved
rootex/framework/scene.cpp Outdated Show resolved Hide resolved
rootex/framework/scene.cpp Outdated Show resolved Hide resolved
rootex/framework/scene.cpp Outdated Show resolved Hide resolved
@Bashar-Ahmed Bashar-Ahmed linked an issue Feb 16, 2022 that may be closed by this pull request
If selected entity is deleted, the editor crashes #534
Open
@Bashar-Ahmed Bashar-Ahmed removed a link to an issue May 16, 2022
If selected entity is deleted, the editor crashes #534
Open
@Bashar-Ahmed Bashar-Ahmed linked an issue Jun 16, 2022 that may be closed by this pull request
Child Scenes should import KeyBindings #529
Closed
angad-k
angad-k requested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@angad-k angad-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename those functions, lgtm otherwise

rootex/core/input/input_manager.cpp Outdated Show resolved Hide resolved
@angad-k angad-k merged commit 1fd7333 into dev Aug 9, 2022
@angad-k angad-k deleted the input branch August 9, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sin3point14 sin3point14 sin3point14 left review comments

@twaritwaikar twaritwaikar twaritwaikar left review comments

@angad-k angad-k angad-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Effectively Map Keys directly to GaInput enums Child Scenes should import KeyBindings
4 participants
@Bashar-Ahmed @twaritwaikar @sin3point14 @angad-k